christian/ppx_stylesheet
1
0
Fork 0
Code Issues 7 Pull requests Projects Releases Packages Wiki Activity Actions

All definitions should have a single argument #3

New issue
Open
opened 2026-03-19 16:10:44 +01:00 by christian · 0 comments
christian commented 2026-03-19 16:10:44 +01:00
Owner
Copy link

I would like to apply the "principle of least surprise" more strictly to the arguments of the CSS definitions.

A CSS definition function should always have exactly one argument which allows passing the most common values. For properties, that allow passing multiple comma-separated values, like backdrop-filter, this means that the function should accept a single value instead of a list:

background_image (url "logo.png")

(* instead of: *)
background_image [ url "logo.png" ]

We should still allow passing multiple values by providing an additional variant of the function. In elm-css those functions have Many suffix. We could just add a ':

(* single value variant (least surprise): *)
background_image (url "logo.png")

(* multiple values variant: *)
background_image' [ (url "lizard.png"); (url "star.png") ] 

(* alternatively do it like in elm-css: *)
background_image_many [ (url "lizard.png"); (url "star.png") ]
I would like to apply the "principle of least surprise" more strictly to the arguments of the CSS definitions. A CSS definition function should always have exactly one argument which allows passing the most common values. For properties, that allow passing multiple comma-separated values, like ``backdrop-filter``, this means that the function should accept a single value instead of a list: ```ocaml background_image (url "logo.png") (* instead of: *) background_image [ url "logo.png" ] ``` We should still allow passing multiple values by providing an additional variant of the function. In ``elm-css`` those functions have ``Many`` suffix. We could just add a `'`: ```ocaml (* single value variant (least surprise): *) background_image (url "logo.png") (* multiple values variant: *) background_image' [ (url "lizard.png"); (url "star.png") ] (* alternatively do it like in elm-css: *) background_image_many [ (url "lizard.png"); (url "star.png") ] ```
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
christian/ppx_stylesheet#3
No description provided.